Skip to content

Removed duplicate ban-types declaration - #23247

Closed
jcoutch wants to merge 1 commit into
microsoft:masterfrom
jcoutch:patch-1
Closed

jcoutch wants to merge 1 commit into
microsoft:masterfrom
jcoutch:patch-1

Conversation

@jcoutch

@jcoutch jcoutch commented Apr 7, 2018 •

Copy link
Copy Markdown

Line 8 defines a list of banned types, while line 96 was setting ban-types to false. After reviewing blame, I'm assuming #19586 is the intended setting, and am removing line 96.

Line 8 defines a list of banned types, while line 96 was setting `ban-types` to false.  After reviewing blame, I'm assuming #19586 is the intended setting, and am removing line 96.
@mhegazy

Copy link
Copy Markdown
Contributor

looks like that change somehow uncovered an unlinted declaration. mind fixing that as well in the same PR

@typescript-bot

Copy link
Copy Markdown
Contributor

Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it.

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants