Skip to content

When importing, only check for reserved type names when importing a type - #31

Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 1 commit into
masterfrom
disallowedNames
Closed

Daniel Rosenwasser (DanielRosenwasser) wants to merge 1 commit into
masterfrom
disallowedNames

Conversation

@DanielRosenwasser

Copy link
Copy Markdown
Member

Given the following

declare module m {
    module s {}
    export import string = s;
}

we would previously give the error

Import name cannot be 'string'

when string is clearly not in conflict with any declared values.

@JsonFreeman

Copy link
Copy Markdown
Contributor

👍

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants