Move class name capture for private state after declaration evaluates - #44186
Merged
Merged
Conversation
Wesley Wigham (weswigham)
approved these changes
May 20, 2021
Kubilay Kahveci (mkubilayk)
approved these changes
May 20, 2021
Contributor
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.3 |
Contributor
|
Heya Ron Buckton (@rbuckton), I've started to run the task to cherry-pick this into |
Contributor
|
Hey Ron Buckton (@rbuckton), I've opened #44188 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 20, 2021
Component commits: acdaf36 Move class name capture for private state until after declaration evaluates
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
May 20, 2021
Component commits: acdaf36 Move class name capture for private state until after declaration evaluates Co-authored-by: Ron Buckton <rbuckton@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our private field transform inadvertently attempted to capture the class declaration during its evaluation when we encountered a computed property name, resulting in a ReferenceError at runtime due to the binding not being initialized.
Fixes #44113
/cc Titian Cernicova-Dragomir (@dragomirtitian), Kubilay Kahveci (@mkubilayk)