Repository navigation
Keyboard events sample in winui3 - #383
Ajit Surana (AjitSurana) merged 5 commits into
Conversation
|
Windows App SDK samples are integrated with the docs samples browser. All feature samples should include metadata in the sample README to integrate with the docs sample browser. For reference: |
|
The guidelines recommend having samples for both C# and C++ at a minimum. On a side note - There is not a hard requirement to cover all the other combinations (e.g. having all UI frameworks, having both Unpackaged and Packaged samples). However, if there is something unique about the specific component, the samples should highlight and showcase these scenarios. |
Saharsh Ananta Jaiswal (Saharsh979)
left a comment
There was a problem hiding this comment.
Add the appropriate copyright notice and license text to the headers.
For C#/C++ files (*h, *.cpp, *.cs, *.idl):
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
For XAML files (*.xaml):
<!-- Copyright (c) Microsoft Corporation.
Licensed under the MIT License. -->
|
/azp run SamplesCI-Input |
|
Commenter does not have sufficient privileges for PR 383 in repo microsoft/WindowsAppSDK-Samples |
|
/azp run SamplesCI-Input |
|
No pipelines are associated with this pull request. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Jeffrey Stall (jeffstall)
left a comment
There was a problem hiding this comment.
Can you remove the C++ version of the sample? It offers no clear value, and it just requires more maintenance.
Please also clean up the C# changes to clarify this is showing WinUI-specific keyboard handling, not generic WinAppSDK keyboard handling.
Jeffrey Stall (jeffstall)
left a comment
There was a problem hiding this comment.
Thanks for making these changes!
|
Has this step about "Onboarding Samples CI Pipeline for new feature" mentioned in the docs been taken care of? |
Port the stable keyboard event and accelerator scenario from main PR #383 while retaining the release project configuration and central package management. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
This PR contains a sample that showcases the implementation of the below keyboard events in WinUI3 Windows App SDK sample app. It consists of both cs and cpp samples.
Checklist
/azp run SamplesCI-<FeatureName>to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.