Repository navigation
WindowsML cpp-abi: enable Control Flow Guard to fix BinSkim BA2008 (release/2.0-experimental) - #656
Merged
agniuks merged 1 commit intoJul 21, 2026
Conversation
CppAbiEPEnumerationSample.exe was built without Control Flow Guard, tripping BinSkim BA2008 (error severity) in the WindowsAppSDK SamplesCompat SDL gate (Guardian: Post Analysis) once the temporary .gdnsuppress waiver (Bug 60433419) expired on 2026-06-30. Set <ControlFlowGuard>Guard</ControlFlowGuard> so cl receives /guard:cf and link receives /GUARD:CF, matching the other WindowsML C++ samples that already pass BA2008. (cherry picked from commit 26eddcd) (cherry picked from commit c4bd030)
Author
|
/azp run |
Felipe G (guimafelipe)
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the CFG fix (#648, commit c4bd030) onto
release/2.0-experimental.CppAbiEPEnumerationSample.exeis built without/guard:cf, so BinSkim BA2008 (error severity) breaks the SamplesCompat SDL gate on every WinAppSDK 2.0-experimental build (e.g. the 2.3.2-ci.experimental autosnap, build 152606950).The fix already shipped to
main,release/2.0-stable, andrelease/experimental; it was never ported torelease/2.0-experimental, which is the branch the aggregator's experimental samples-compat job builds (SamplesBranch: release/2.0-experimental). This closes that gap.Original fix authored by Kyaw Thant (@kythant); parallel fix (
e32efe4d) by v-arlysenko.