Repository navigation
Use unified data types in LoongArch SIMD intrinsics - #602
Merged
Merged
Conversation
Prior to Rust `nightly-2025-08-08`, LoongArch SIMD intrinsics used distinct vector types such as `v4i32`, `v8i32`, and others. Passing data between intrinsics of different types required explicit `mem::transmute` calls, introducing unnecessary boilerplate and complexity. This change adopts unified `m128i` and `m256i` types for all LoongArch SIMD intrinsics, eliminating redundant conversions and simplifying cross-intrinsic data handling.
Leonard Hecker (lhecker)
approved these changes
Aug 12, 2025
Leonard Hecker (lhecker)
left a comment
Member
There was a problem hiding this comment.
Thank you for maintaining this code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to Rust
nightly-2025-08-08, LoongArch SIMD intrinsics used distinct vector types such asv4i32,v8i32, and others. Passing data between intrinsics of different types required explicitmem::transmutecalls, introducing unnecessary boilerplate and complexity.This change adopts unified
m128iandm256itypes for all LoongArch SIMD intrinsics, eliminating redundant conversions and simplifying cross-intrinsic data handling.