Repository navigation
windows: fix the compatibility section of the manifest - #635
Merged
Merged
Conversation
Member
Author
|
I also audited the other ones--the windowsSettings ones--and they seemed to work fine despite application being in asmv3 and windowsSettings being in asmv1. |
Jenia Dysin (jenia90)
pushed a commit
to jenia90/edit
that referenced
this pull request
Jan 30, 2026
So, it turns out that `supportedOS` was being ignored because it was taken to be in the default `asm.v1` namespace. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, it turns out that
supportedOSwas being ignored because it was taken to be in the defaultasm.v1namespace. :)