Repository navigation
Fix stability of compare_strings_ascii - #823
Merged
Merged
Conversation
| // case-insensitive equal, because then we use that as a fallback. | ||
| while let Some((&a, &b)) = iter.next() { | ||
| if a != b { | ||
| let mut order = a.cmp(&b); |
Member
Author
There was a problem hiding this comment.
The default value for order must always be la.cmp(&lb) (high weight: case-insensitive). Only if it's Equal must it fall back to a.cmp(&b) (low weight: case-sensitive).
Dustin L. Howett (DHowett)
approved these changes
Apr 27, 2026
Leonard Hecker (lhecker)
enabled auto-merge (squash)
April 27, 2026 19:27
auto-merge was automatically disabled
April 27, 2026 19:27
Pull request was closed
Leonard Hecker (lhecker)
enabled auto-merge (squash)
April 27, 2026 19:28
Member
|
Leonard Hecker (@lhecker) how on earth did this fix a crash in the file picker |
Member
Author
|
Dustin L. Howett (@DHowett) Rust detects non-deterministic sorters at runtime. This bug caused vmlinuz2 < w32process.ps1 < Willkommen, but also vmlinuz2 > Willkommen, which is impossible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #822