Skip to content

Fix/content length - #1119

Merged
Vincent Biret (baywet) merged 7 commits into
mainfrom
fix/content-length
Apr 19, 2024
Merged

Vincent Biret (baywet) merged 7 commits into
mainfrom
fix/content-length

Conversation

@Ndiritu

@Ndiritu Philip Gichuhi (Ndiritu) commented Mar 18, 2024 •

Copy link
Copy Markdown
Contributor

Only override content-length with values from Content-Length header or if the body is a ByteArrayInputStream since the available() method is reliable from the array size backing the stream.

closes #1110
closes microsoftgraph/msgraph-sdk-java#1883

Pending:

  • Integration testing
  • Large File Upload Scenarios

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will take a look shortly.

@Ndiritu Philip Gichuhi (Ndiritu) changed the title WIP Fix/content length Fix/content length Apr 16, 2024
@Ndiritu
Philip Gichuhi (Ndiritu) marked this pull request as ready for review April 16, 2024 06:55
@sonarqubecloud

Copy link
Copy Markdown

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet
Vincent Biret (baywet) merged commit 6bed700 into main Apr 19, 2024
@baywet
Vincent Biret (baywet) deleted the fix/content-length branch April 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Upload small file require Content-Length header to put method solving for content-length request header

2 participants