Skip to content

Revert from Async to Sync - #770

Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 11 commits into
mainfrom
rsh/syncRevert_java
Nov 10, 2023
Merged

Revert from Async to Sync #770
Ramses Sanchez-Hernandez (ramsessanchez) merged 11 commits into
mainfrom
rsh/syncRevert_java

Conversation

@ramsessanchez

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) commented Nov 3, 2023 •
edited by baywet
Loading

Copy link
Copy Markdown
Contributor

Begin work to revert from Async to Sync for Java-Kiota components.

fixes #175

baywet
Vincent Biret (baywet) requested changes Nov 6, 2023
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this, a couple of comments to help fasttrack it.

Comment thread components/abstractions/src/main/java/com/microsoft/kiota/ResponseHandler.java Outdated
Comment thread ...tractions/src/main/java/com/microsoft/kiota/authentication/ApiKeyAuthenticationProvider.java
Comment thread ...actions/src/main/java/com/microsoft/kiota/serialization/SerializationWriterProxyFactory.java
Comment thread ...azure/src/main/java/com/microsoft/kiota/authentication/AzureIdentityAccessTokenProvider.java
Comment thread .../http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/HeadersInspectionHandler.java
Comment thread components/abstractions/src/main/java/com/microsoft/kiota/RequestAdapter.java Outdated
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated
@ramsessanchez

Ramses Sanchez-Hernandez (ramsessanchez) commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

appreciate the feedback and insight Vincent Biret (@baywet) , thanks!

@ramsessanchez
Ramses Sanchez-Hernandez (ramsessanchez) marked this pull request as ready for review November 6, 2023 22:46
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2023

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

andrueastman
Andrew Omondi (andrueastman) reviewed Nov 7, 2023
View reviewed changes
Comment thread ...azure/src/main/java/com/microsoft/kiota/authentication/AzureIdentityAccessTokenProvider.java Outdated
Comment thread ...tions/src/test/java/com/microsoft/kiota/authentication/ApiKeyAuthenticationProviderTest.java
Comment thread .../src/main/java/com/microsoft/kiota/authentication/BaseBearerTokenAuthenticationProvider.java Outdated
Comment thread components/abstractions/src/main/java/com/microsoft/kiota/MultipartBody.java
@sonarqubecloud

sonarqubecloud Bot commented Nov 7, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

baywet
Vincent Biret (baywet) reviewed Nov 7, 2023
View reviewed changes
Comment thread components/http/okHttp/gradle/dependencies.gradle
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will take a look shortly.

@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2023

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2023

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 43 Code Smells

0.0% 0.0% Coverage
22.1% 22.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2023

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@ramsessanchez
Api Exception handling
cbe580b 
Changelog and Version
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 48 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

baywet
Vincent Biret (baywet) requested changes Nov 10, 2023
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close!

Comment thread CHANGELOG.md Outdated
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/HeadersCompatibility.java
Comment thread gradle.properties
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated
Comment thread components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java Outdated
@sonarqubecloud

sonarqubecloud Bot commented Nov 10, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Nov 10, 2023

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud

sonarqubecloud Bot commented Nov 10, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

baywet
Vincent Biret (baywet) approved these changes Nov 10, 2023
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the changes

@ramsessanchez
Ramses Sanchez-Hernandez (ramsessanchez) deleted the rsh/syncRevert_java branch November 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet Vincent Biret (baywet) baywet approved these changes
@MIchaelMainer Michael Mainer (MIchaelMainer) Awaiting requested review from MIchaelMainer
@zengin Mustafa Zengin (zengin) Awaiting requested review from zengin
@andreaTP Andrea Peruffo (andreaTP) Awaiting requested review from andreaTP
@EricWittmann Eric Wittmann (EricWittmann) Awaiting requested review from EricWittmann
@andrueastman Andrew Omondi (andrueastman) Awaiting requested review from andrueastman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[discussion] Java Async

5 participants

@ramsessanchez @EricWittmann @andreaTP @andrueastman @baywet