Skip to content

Remove enum reflection - #843

Merged
Vincent Biret (baywet) merged 10 commits into
microsoft:mainfrom
andreaTP:rem-enum-reflection
Nov 22, 2023
Merged

Remove enum reflection#843
Vincent Biret (baywet) merged 10 commits into
microsoft:mainfrom
andreaTP:rem-enum-reflection

Conversation

@andreaTP

@andreaTP Andrea Peruffo (andreaTP) commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Proposal to fix #840

baywet
Vincent Biret (baywet) approved these changes Nov 21, 2023
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. I think we should bump the minor and release the packages as soon as the generation changes are in.

baywet
Vincent Biret (baywet) requested changes Nov 21, 2023
View reviewed changes
Comment thread components/abstractions/src/main/java/com/microsoft/kiota/RequestAdapter.java
Comment thread components/abstractions/src/main/java/com/microsoft/kiota/RequestAdapter.java
@andreaTP

Andrea Peruffo (andreaTP) commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

I'm converting from Lambdas to plain classes to achieve compatibility, leave this on me Vincent Biret (@baywet) if you don't mind.

@baywet

Vincent Biret (baywet) commented Nov 21, 2023

Copy link
Copy Markdown
Member

I'm converting from Lambdas to plain classes to achieve compatibility, leave this on me Vincent Biret (@baywet) if you don't mind.

do you mean using this syntax instead of a lambda EnumName::forValue ?

@andreaTP

Andrea Peruffo (andreaTP) commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

I done the changes to make the linter happy and expanded the functional interface into a real interface, let me know if this looks good.

baywet
Vincent Biret (baywet) requested changes Nov 21, 2023
View reviewed changes
Comment thread components/abstractions/src/main/java/com/microsoft/kiota/serialization/ValuedEnumParser.java
Comment thread components/abstractions/src/main/java/com/microsoft/kiota/RequestAdapter.java
Comment thread CHANGELOG.md
@andreaTP @baywet
Update components/abstractions/src/main/java/com/microsoft/kiota/seri…
d608598 
…alization/ValuedEnumParser.java

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@andreaTP
update changelog
54ad1c7
@andreaTP
minor
95040ab
@andreaTP
args reordering
f7fe7a6
@andreaTP

Andrea Peruffo (andreaTP) commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

should be good for a final review now 👍

@andreaTP

Andrea Peruffo (andreaTP) commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

maybe not, let me double-check, sorry for the noise.

@andreaTP
Andrea Peruffo (andreaTP) marked this pull request as draft November 21, 2023 17:19
@andreaTP
Andrea Peruffo (andreaTP) marked this pull request as ready for review November 21, 2023 17:29
@andreaTP Andrea Peruffo (andreaTP) mentioned this pull request Nov 21, 2023
Merged
baywet
Vincent Biret (baywet) approved these changes Nov 22, 2023
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet
Vincent Biret (baywet) merged commit 1beb9ae into microsoft:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet Vincent Biret (baywet) baywet approved these changes
@MIchaelMainer Michael Mainer (MIchaelMainer) Awaiting requested review from MIchaelMainer
@zengin Mustafa Zengin (zengin) Awaiting requested review from zengin
@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) Awaiting requested review from ramsessanchez
@andrueastman Andrew Omondi (andrueastman) Awaiting requested review from andrueastman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid usage of reflection API in Enum deserialization

2 participants

@andreaTP @baywet