Repository navigation
fix: controlling terminal on macOS - #589
Merged
Merged
Conversation
Daniel Imms (Tyriar)
approved these changes
Mar 31, 2023
Daniel Imms (Tyriar)
enabled auto-merge
March 31, 2023 17:16
Kartik Raj (karrtikr)
approved these changes
Mar 31, 2023
xiaobaidadada
pushed a commit
to xiaobaidadada/node-pty-prebuilt
that referenced
this pull request
Feb 25, 2025
fix: controlling terminal on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs microsoft/vscode#178693
Depends on #588
This brings back the helper executable to associate a controlling terminal for the child process created under new session, the change still ensures microsoft/vscode#174956 is addressed.