Repository navigation
Conversation
* feat: remove mac condition * feat: remove condition
|
Hello, João Moreno (@joaomoreno) Benjamin Pasero (@bpasero) Robo (@deepak1556) |
|
Thanks for your contribution! The flag changes should come from the runtime which ships the relevant v8 headers, this should be addressed for Electron via electron/electron#36369 Are you compiling this module for Nodejs or Electron ? |
|
Yes, I am compiling this module for Electron. I will address the issue in electron/electron#36369! Thank you for bringing this to my attention. |
|
Closing as issue is addressed in upstream. |
V8 headers now use
c++17by default. This flag was added for supportsc++17.