Skip to content

Supports c++17 - #10

Closed
paulyangg wants to merge 2 commits into
microsoft:mainfrom
ProtoPie:main
Closed

paulyangg wants to merge 2 commits into
microsoft:mainfrom
ProtoPie:main

Conversation

@paulyangg

Copy link
Copy Markdown

V8 headers now use c++17 by default. This flag was added for supports c++17.

paulyangg and others added 2 commits September 28, 2022 21:23
* feat: remove mac condition

* feat: remove condition
@paulyangg
paulyangg marked this pull request as draft December 19, 2022 07:37
@paulyangg
paulyangg marked this pull request as ready for review December 19, 2022 07:37
@paulyangg

Copy link
Copy Markdown
Author

Hello,
I am submitting a patch that allows window-mutex to be compiled with C++17. I have tested the code and it works as intended.
Please review my code and consider merging it into the project. Thank you for your time and consideration.
Best regards, Paul Yang

João Moreno (@joaomoreno) Benjamin Pasero (@bpasero) Robo (@deepak1556)

@deepak1556

Copy link
Copy Markdown
Contributor

Thanks for your contribution! The flag changes should come from the runtime which ships the relevant v8 headers, this should be addressed for Electron via electron/electron#36369

Are you compiling this module for Nodejs or Electron ?

@paulyangg

Copy link
Copy Markdown
Author

Yes, I am compiling this module for Electron. I will address the issue in electron/electron#36369! Thank you for bringing this to my attention.

@deepak1556

Copy link
Copy Markdown
Contributor

Closing as issue is addressed in upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants