Skip to content

Enforce fixes for missing docs - #1860

Merged
Travis Prescott (tjprescott) merged 12 commits into
microsoft:mainfrom
tjprescott:docs/FixMissingDocs
Apr 28, 2023
Merged

Travis Prescott (tjprescott) merged 12 commits into
microsoft:mainfrom
tjprescott:docs/FixMissingDocs

Conversation

@tjprescott

@tjprescott Travis Prescott (tjprescott) commented Apr 24, 2023 •

Copy link
Copy Markdown
Member

This PR make it so that docs generation fails if anything that should have docs does not. As a result, it will also have a ton of doc fixes.

This also adds ref doc generation for scalars and fixes a logic bug in the generation of docs.

TODO

  • decorators
  • decorator parameters
  • template parameters
  • models
  • unions
  • enums
  • interfaces
  • operations
  • scalars

Example output:

Issues in @typespec/compiler:
Missing documentation for template parameter 'Array.T'.
Missing documentation for template parameter 'Record.T'.
Missing documentation for template parameter 'OptionalProperties.T'.
Missing documentation for template parameter 'UpdateableProperties.T'.
Missing documentation for template parameter 'OmitProperties.T'.
Missing documentation for template parameter 'OmitProperties.TKeys'.
Missing documentation for template parameter 'OmitDefaults.T'.
Missing documentation for template parameter 'DefaultKeyVisibility.T'.
Missing documentation for template parameter 'DefaultKeyVisibility.Visibility'.
Missing documentation for decorator '@withUpdateableProperties'.
Missing documentation for decorator parameter '@withoutOmittedProperties.omit'.
Missing documentation for decorator '@withoutOmittedProperties'.
Missing documentation for decorator '@withoutDefaultValues'.
Missing documentation for decorator parameter '@withDefaultKeyVisibility.visibility'.
Missing documentation for decorator '@withDefaultKeyVisibility'.
Missing documentation for decorator parameter '@friendlyName.formatArgs'.
Missing documentation for decorator parameter '@key.altName'.
Missing documentation for decorator parameter '@discriminator.propertyName'.
Missing documentation for decorator parameter '@visibility.visibilities'.
Missing documentation for decorator parameter '@withVisibility.visibilities'.
Missing documentation for decorator parameter '@inspectType.text'.
Missing documentation for decorator '@inspectType'.
Missing documentation for decorator parameter '@inspectTypeName.text'.
Missing documentation for decorator '@inspectTypeName'.

Issues in @typespec/http:
Missing documentation for template parameter 'ApiKeyAuth.TLocation'.
Missing documentation for template parameter 'ApiKeyAuth.TName'.
Missing documentation for template parameter 'OAuth2Auth.TFlows'.
Missing documentation for decorator parameter '@includeInapplicableMetadataInPayload.value'.
Missing documentation for decorator parameter '@route.options'.

@github-actions

Copy link
Copy Markdown
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/1860/

Website: https://cadlwebsite.z1.web.core.windows.net/prs/1860/

Comment thread packages/ref-doc/src/extractor.ts Outdated
@tjprescott
Travis Prescott (tjprescott) force-pushed the docs/FixMissingDocs branch 3 times, most recently from fab5c1e to 37c3967 Compare April 25, 2023 19:52
Comment thread packages/ref-doc/src/experimental.ts Outdated
Comment thread packages/ref-doc/src/extractor.ts
Comment thread packages/ref-doc/src/experimental.ts Outdated
Comment thread packages/compiler/lib/decorators.ts
Comment thread packages/ref-doc/src/extractor.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants