Repository navigation
Remove includeRootSlash client option logic from http-client-python - #9964
Merged
Chenjie Shi (tadelesh) merged 3 commits intoMar 9, 2026
Merged
Conversation
This logic was using a customized decorator (@clientoption("includeRootSlash")) to control stripping of the leading slash from operation paths. This is a TypeSpec core issue and should not be handled with a customized decorator. Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove includeRootSlashOption logic from http-python-client
Remove includeRootSlash client option logic from http-client-python
Mar 9, 2026
Chenjie Shi (tadelesh)
approved these changes
Mar 9, 2026
Chenjie Shi (tadelesh)
marked this pull request as ready for review
March 9, 2026 05:28
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Yuchao Yan (msyyc)
approved these changes
Mar 9, 2026
Chenjie Shi (tadelesh)
deleted the
copilot/remove-includerootslashoption-logic
branch
March 9, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@clientOption("includeRootSlash")decorator was a workaround in the Python emitter to control stripping the leading slash from operation paths. This is a TypeSpec core concern and should not be solved via a custom decorator.getClientOptionsimport (only consumer)includeRootSlashoptionoperation.pathdirectly instead of conditionally stripping the leading slash💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.