You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update Library.Template and enable xUnit NativeAOT tests - #1710
Bring in the latest Library.Template microbuild updates and NativeAOT coverage without replacing this repository's xUnit test framework or dropping its older managed test targets.
Approach
Merge Library.Template microbuild commit b050e25685b1d3a0fb997e6037f68f7bd37b97ff, including build, CI, tooling, documentation authentication, and testing guidance updates while preserving repository-specific configuration.
Add .NET 10 to the threading tests and conditionally select xunit.v3.aot.mtp-v2 for that target. Older targets retain the reflection-based runner; analyzer tests remain managed-only.
Replace reflection-only combinatorial data with explicit InlineData, and shared STA/UI discoverers with thread helpers that preserve apartment state, synchronization context, and thread affinity. Keep framework-only STA tests on their existing extension.
Wire native test discovery, publishing, and execution into traversal builds and CI. Preserve both .NET 10 compatibility probes and static-graph restore.
Validation
Validated on Windows x64:
Managed cloud run: 6,303 passed, 63 existing skips, no failures.
Published NativeAOT run: 1,087 passed, nine existing skips, no failures.
Final traversal restore and publish with warnings treated as errors succeeded; native discovery selects exactly one unit-test variant, net10.0.
Follow-up STA/helper checks passed on all four managed targets and the native executable. Attribute formatting preserves every theory data case.
Cross-platform runtime execution has not been validated locally.
Re-running a failed docs deployment failed because the prior attempt's
github-pages artifact remained, making deploy-pages find two artifacts.
Use a per-attempt artifact name, and allow workflow_dispatch.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…lls (593)
Machine-wide installs checked for already-installed SDKs and runtimes under the
native Program Files dotnet directory regardless of the process architecture.
In x86 PowerShell on x64 Windows, or x64 PowerShell on ARM64 Windows, that is
the wrong root, so missing components could be skipped. Select the root where
each architecture's installer actually puts them.
CFSClean2 is included by default (at least for some pipelines) but CFSClean is *not* and we're getting compliance issues filed because nuget.org is reached.
Adding CFSClean explicitly solves it.
Pass the tree-node filter as a single option argument for managed and NativeAOT test runs to avoid platform-specific argument parsing failures.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pass the tree-node filter as a single option argument for managed and NativeAOT test runs to avoid platform-specific argument parsing failures.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Select AOT and reflection runners per target framework while preserving older managed targets. Replace reflection-only theory data and shared STA/UI discoverers with explicit data and thread helpers, retaining framework-only STA tests.
Wire native test discovery and publishing into traversal builds, preserve compatibility probes on both .NET 10 targets, and fix static-graph restore and native output path handling. Document the retained xUnit workflow.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
One or more custom setup steps configured for this repository failed during this Copilot code review run:
⚙ Install prerequisites
Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.
Note
You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.
Retain the approved-feed dotnet-symbol version, forward prerequisite upgrade requests to runtime detection, and enable native hang diagnostics under Windows PowerShell. Add regression checks for both PowerShell editions and avoid redundant Unsafe package references on modern test targets.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Queue frame shutdown through its synchronization context so completion cannot race PushFrame owner assignment. Cover synchronous UI actions and bound native test runs on every platform with a five-minute timeout.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This repeats the all-tests command. From the repository root it runs the solution's test projects, rather than one project as advertised. Add --project with the threading test project path to scope this example correctly.
Specify the threading project for dotnet run
.agents/skills/testing/SKILL.md:52
Unlike dotnet test, dotnet run does not select a project from the solution. This command fails from the repository root, which has no runnable project, and the example does not instruct readers to change directories. Specify the threading test project explicitly.
🧠 Review effort: Balanced
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bring in the latest Library.Template microbuild updates and NativeAOT coverage without replacing this repository's xUnit test framework or dropping its older managed test targets.
Approach
b050e25685b1d3a0fb997e6037f68f7bd37b97ff, including build, CI, tooling, documentation authentication, and testing guidance updates while preserving repository-specific configuration.xunit.v3.aot.mtp-v2for that target. Older targets retain the reflection-based runner; analyzer tests remain managed-only.InlineData, and shared STA/UI discoverers with thread helpers that preserve apartment state, synchronization context, and thread affinity. Keep framework-only STA tests on their existing extension.Validation
Validated on Windows x64:
net10.0.Cross-platform runtime execution has not been validated locally.