Repository navigation
Add CUDA support - #7255
Merged
Merged
Add CUDA support#7255
Conversation
Contributor
|
Did you figure out a solution to the issue mentioned in the description? Does the await util.checkCuda() work? |
Contributor
Author
I updated/corrected the description. Bob had since pointed me to a better place to put that check. |
Sean McManus (sean-mcmanus)
requested changes
Mar 31, 2021
Sean McManus (sean-mcmanus)
left a comment
Contributor
There was a problem hiding this comment.
keybindings change?
…nto coleng/add_cuda_support
…t/vscode-cpptools into coleng/add_cuda_support
Sean McManus (sean-mcmanus)
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A global
supportCudais set only on activation. If the language ID is not registered, all CUDA support should effectively be disabled. Since the cuda-cpp language ID is being added to VS Code itself, we don't expect the availability of the language ID to change at runtime.Eventually, we could remove the supportCuda setting, when/if we update the version requirement for VS Code to a version that include the cuda-cpp language ID.