Skip to content

Add CUDA support - #7255

Merged
Colen Garoutte-Carson (Colengms) merged 9 commits into
mainfrom
coleng/add_cuda_support
Mar 31, 2021
Merged

Colen Garoutte-Carson (Colengms) merged 9 commits into
mainfrom
coleng/add_cuda_support

Conversation

@Colengms

@Colengms Colen Garoutte-Carson (Colengms) commented Mar 29, 2021 •

Copy link
Copy Markdown
Contributor

A global supportCuda is set only on activation. If the language ID is not registered, all CUDA support should effectively be disabled. Since the cuda-cpp language ID is being added to VS Code itself, we don't expect the availability of the language ID to change at runtime.

Eventually, we could remove the supportCuda setting, when/if we update the version requirement for VS Code to a version that include the cuda-cpp language ID.

Comment thread Extension/package.json Resolved
@sean-mcmanus

Copy link
Copy Markdown
Contributor

Did you figure out a solution to the issue mentioned in the description? Does the await util.checkCuda() work?

@Colengms

Copy link
Copy Markdown
Contributor Author

Did you figure out a solution to the issue mentioned in the description? Does the await util.checkCuda() work?

I updated/corrected the description. Bob had since pointed me to a better place to put that check.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keybindings change?

@Colengms
Colen Garoutte-Carson (Colengms) deleted the coleng/add_cuda_support branch March 31, 2021 22:49
@github-actions github-actions Bot locked and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants