Skip to content

creates file watcher with trailing slash causes problems for other extensions #828

Closed

Description

Investigating microsoft/vscode-spring-boot-dashboard#324 and spring-projects/spring-tools#1231 revealed that the Project Manager for Java extension in VSCode seems to create a file watcher that contains a trailing slash for the root path, which should not be done (according to spring-projects/spring-tools#1231 (comment)).

It causes problems down the road with other extensions, since future file events when contain a wrong URI for the changed file, containing a duplicated / between the root path and the relative file path in the workspace.

Activity

  1. martinlippert commented on Apr 18, 2024

    @martinlippert
    Author

    Jinbo Wang (@testforstephen) Would be awesome if you could have a look.

  2. added 2 commits that reference this issue on Apr 19, 2024
    544aa98
    25d487b
  3. testforstephen commented on Apr 19, 2024

    @testforstephen
    Contributor

    this has been fixed in the pre-release version 0.23.2024041907 of Project Manager for Java extension. feel free to have a try.

  4. martinlippert commented on Apr 19, 2024

    @martinlippert
    Author

    LGTM, thanks for this fix. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions