Skip to content

Fix the bug that clicking on node will navigate the the position which contains comments #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheng Chen (jdneo) merged 2 commits into from
Dec 10, 2018
Merged

Fix the bug that clicking on node will navigate the the position which contains comments #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b38ec73
Fix the bug that clicking on node will navigate to the comments
jdneo Dec 7, 2018
b49acea
Add a comment
jdneo Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/views/documentSymbolNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export class DocumentSymbolNode extends BaseSymbolNode {
}

protected get range(): Range {
return (<DocumentSymbol>this.symbolInfo).range;
// Using `selectionRange` instead of `range` to make sure the cursor will be pointing to the codes, not the comments
return (<DocumentSymbol>this.symbolInfo).selectionRange;
}
}