Repository navigation
feat: Add inline button for create new class - #331
Merged
Merged
Conversation
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY),
Yan Zhang (Eskibear) and
Jinbo Wang (testforstephen)
September 22, 2020 08:45
Yan Zhang (Eskibear)
approved these changes
Sep 22, 2020
Yan Zhang (Eskibear)
left a comment
Member
There was a problem hiding this comment.
LGTM, just wonder if we should use the same icon (+) with "create a project". Consider icon new-file ?
Member
Author
That's a valid concern. Rome Li (@akaroml) What do you think? IMO |
Jinbo Wang (testforstephen)
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
create new classaction as an inline button forproject,packageRoot&packagenodes