Repository navigation
feat: Report messages when exporting jar - #499
Merged
Merged
Conversation
Shi Chen (CsCherrYY)
force-pushed
the
exportReport
branch
from
May 20, 2021 08:18
3828310 to
84e3578
Compare
| new CustomExecution(async (resolvedDefinition: IExportJarTaskDefinition): Promise<Pseudoterminal> => { | ||
| const stepMetadata: IStepMetadata = { | ||
| entry: undefined, | ||
| taskLabel: resolvedDefinition.label || `${ExportJarTaskProvider.exportJarType}: exportjar:${folder.name}`, |
Contributor
There was a problem hiding this comment.
No need to append ${ExportJarTaskProvider.exportJarType}: before the task label.
| try { | ||
| writeFile(new File(classpath.source), new Path(classpath.destination), /* areDirectoryEntriesIncluded = */true, | ||
| /* isCompressed = */true, target, directories); | ||
| reportExportJarMessage(taskLabel, IStatus.OK, "successfully export " + classpath.destination); |
Contributor
There was a problem hiding this comment.
Successfully added the file to the exported jar: classpath.destination
| int severity = resultStatus.getSeverity(); | ||
| if (severity == IStatus.OK) { | ||
| java.nio.file.Path path = java.nio.file.Paths.get(classpath.source); | ||
| reportExportJarMessage(taskLabel, IStatus.OK, "successfully export " + path.getFileName().toString()); |
Contributor
There was a problem hiding this comment.
The message is not accurate.
Successfully added the file to the exported jar: path.getFileName().toString()
Jinbo Wang (testforstephen)
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #374