Repository navigation
ux - display maven and gradle dependencies with pattern 'groupId:artifactId:version ' - #859
Conversation
|
Hi Sheng Chen (@jdneo) , this is my view of the implementation for #857, though I am not fully satisfied with changes, as I had to introduce getLabel() method to ExplorerNode. It seems that this only works for Maven, as when gradle project is loaded, the jdtls is not recognizing dependencies as Gradle, instead it is. :/ Could you please take a look and let me know what I might have done better? Also, is there a requirement to test his functionality? |
|
@microsoft-github-policy-service agree |
|
Overall looks good to me. Are you willing to add a test case in the |
I'm definitely willing to add a test case. It would be a great learning opportunity for me, though it might take some time. That said, it depends on how quickly we’re looking to merge this. Let me know what works best! |
|
I'm not hurry, just take your time 😉 |
|
Sheng Chen (@jdneo), 2 tests are failing, though I am not sure if that is intended, as the latest build from main branch reflect the same result, https://github.com/microsoft/vscode-java-dependency/actions/runs/10659297304/job/29541618151 |
|
It's unlikely the failures are caused by this PR. Please give me some time to do some investigation (I was occupied by some other stuff recently). If I cannot get some finding I'll merge this PR first. |
|
I tested on my mac but I cannot reproduce it. |
|
Marko Milic (@mamilic) Thanks for your contribution! I appended a commit to pass the test. I guess it's related with some timing issue. Since gradle project needs to download gradle distribution during import in CI jobs. It will take longer time. |
|
Sheng Chen (@jdneo), thank you for your patience and guidence on this issue, and do apologies for taking so long. Next step is to enable this for gradle. |
This MR referes to the issue, #857