Debugger can't terminate on program end #11

Activity

1. roblourens

   added

   bug

   and removed

   bug

   on Sep 7, 2016
2. roblourens commented on Sep 7, 2016

   

   roblourens

   on Sep 7, 2016

   MemberAuthor

   More actions

   Node in some versions has a similar issue, so this probably isn't high priority.
3. roblourens commented on Sep 21, 2016

   

   roblourens

   on Sep 21, 2016

   MemberAuthor

   More actions

   I could listen on stderr for "Waiting for the debugger to disconnect..." but not a good solution
4. roblourens

   added

   blocked

   on Sep 22, 2016
5. mousetraps commented on Sep 27, 2016

   

   Sara Itani (mousetraps)

   on Sep 27, 2016

   More actions

   Interestingly, after hitting this issue, I pressed step over a gazillion times, and the process actually exited at the end.
6. rianadon commented on Jun 19, 2017

   

   rianadon

   on Jun 19, 2017

   Contributor

   More actions

   Now that nodejs/node#7742 has been resolved, what needs to be done to fix this?

   I'd be happy to provide a PR but given that the bulk of functionality comes from vscode-chrome-debug-core, I'm not sure where to fix this.
7. roblourens commented on Jun 19, 2017

   

   roblourens

   on Jun 19, 2017

   MemberAuthor

   More actions

   Thanks for pointing that out, I should have subscribed to the issue. A PR would be awesome, it should be fairly simple. The fix will be in this repo, at least for now.

   Override protected hookConnectionEvents(): void { from -core's ChromeDebugAdapter. Add a listener for the Runtime.executionContextDestroyed event. Check that the id=1 (I don't know what else in node would cause a context to be created and destroyed? And call terminateSession when that happens.
8. rianadon

   added a commit that references this issue on Jun 19, 2017

   Stop debugging on program end - Fix microsoft#11

   This issue will close once commit 8f2d82a is merged into the 'master' branch.

   8f2d82a
9. rianadon commented on Jun 19, 2017

   

   rianadon

   on Jun 19, 2017

   Contributor

   More actions

   Thanks for all those instructions! If you haven't already seen it the PR is #112.
10. roblourens

    closed this as completedin #112on Jun 19, 2017
11. Andre Weinand (weinand)

    added this to the June 2017 milestone on Jun 28, 2017
12. roblourens

    added a commit that references this issue on Jul 20, 2017

    Stop debugging on program end - Fix #11

    This issue will close once commit 26d32f3 is merged into the 'main' branch.

    26d32f3
13. vscodebot

    locked and limited conversation to collaborators on Mar 29, 2018