Skip to content

PR views: do not use inline actions #2179

Closed

Description

@alexr00

From Isidor Nikolic (@isidorn)

Currently the PR extension uses inline actions for the following cases that I could find

PULL REQUESTS: Open Pull Request Description to the Side
ISSUES: Start Work on Issue and Open Issue
Might there be more I am missing?

My suggestion: to make the whole view experience calmer do not use inline actions. Simply put those actions in the context menu. Especially for the PULL REQUESTS view since the action does not seem that important.
In issues view I would do the same and just make double click to start work on issue (if you can distungish single vs double click). Or Enter. And same as in PULL REQUESTS view I would simply add these actions to the context menu

Inline actions are hectic, they appear and disapear and they add unneded details to an already full view.

Just my 2 cents.

Activity

  1. alexr00 commented on Sep 29, 2020

    @alexr00
    MemberAuthor

    I see the goal of inline actions as twofold:

    1. Make the most common action fast to use.
    2. Reveal an action that is very useful, but otherwise hard to discover.

    I think that there are several inline actions that do not fit that paradigm. We should do a deliberate pass over inline actions, but I don't think we will remove all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

wont-fixThis will not be worked on

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions