Skip to content

Fix solution restore after Rust PoC commit - #1000

Merged
shps951023 merged 2 commits into
masterfrom
fix/remove-miniexcelrust-sibling-reference
Sep 5, 2026
Merged

shps951023 merged 2 commits into
masterfrom
fix/remove-miniexcelrust-sibling-reference

Conversation

@shps951023

@shps951023 shps951023 commented Sep 5, 2026 •

Copy link
Copy Markdown
Member

Root cause

Commit e1cec4f added a solution project path pointing to the sibling MiniExcelRust repository. GitHub Actions only checks out MiniExcel, so both .NET and CodeQL failed during restore with MSB3202.

Fix

  • remove only the external ../MiniExcelRust/... project reference
  • keep the in-repository Rust PoC and benchmark projects unchanged

Validation

  • dotnet restore MiniExcel.slnx
  • dotnet build MiniExcel.slnx -c Release --no-restore (success; existing warnings only)

Summary by CodeRabbit

  • Chores
    • Removed two package test project references from the solution configuration.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e00f49f4-65f5-4d48-9704-c122a0ed16a3

📥 Commits

Reviewing files that changed from the base of the PR and between 1cdeaf6 and 5de51f7.

📒 Files selected for processing (1)
  • MiniExcel.slnx
💤 Files with no reviewable changes (1)
  • MiniExcel.slnx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The solution removes two package test project references from MiniExcel.slnx.

Changes

Solution cleanup

Layer / File(s) Summary
Remove obsolete project references
MiniExcel.slnx
The solution no longer includes the MiniExcel.Rust.PackageTests.csproj and MiniExcelRust.PackageTests.csproj project entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5de51

The solution cleanup removes obsolete restore inputs; no concrete merge-blocking impact is identified in the supplied change context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing solution restore failures caused by the Rust proof-of-concept commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-miniexcelrust-sibling-reference

Comment @coderabbitai help to get the list of available commands.

@shps951023
shps951023 merged commit ff02057 into master Sep 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant