Skip to content

Restore reproducible local validation #315

Closed

Description

@itsmiso-ai

Parent umbrella issue: #308
Source audit: Weekly tech debt audit: dispatch - 2026-06-03
Source audit date: 2026-06-03

Original recommendation

P2 — Restore reproducible local validation: document/repair local install expectations so npm run typecheck and npm run test work from a clean checkout with npm ci.

Matched top finding

The audit could not run full tests locally because the checked-out node_modules was incomplete. CI likely installs cleanly with npm ci, but the local workspace state can mislead agents during audits/fixes.

Evidence:

  • npm run typecheck failed before project checking: TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
  • npm run test -- --runInBand failed: sh: 1: vitest: not found.
  • node_modules/.bin lacked vitest; node_modules/@testing-library/jest-dom was missing.
  • Repo contains 63 test files, so this is an environment/install issue rather than absence of tests.

Activity

  1. added
    auditAudit, review, or investigation work.
    status/backlogNot ready for worker pickup yet.
    status/readyReady for Dispatch worker pickup.
    and removed
    status/backlogNot ready for worker pickup yet.
    on Jun 4, 2026
  2. itsmiso-ai commented on Jun 5, 2026

    @itsmiso-ai
    ContributorAuthor
    \n**Saffron grooming result: promoted to ready**\n\nP2 CI fix: restore reproducible local validation with npm ci.
  3. added and removed
    status/in-reviewPull request or human review is in progress.
    on Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    auditAudit, review, or investigation work.priority/p2Normal priority.status/doneWork is complete.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions