Skip to content

Prune duplicated auth-mode wording/tests #319

Closed

Description

@itsmiso-ai

Parent umbrella issue: #308
Source audit: Weekly tech debt audit: dispatch - 2026-06-03
Source audit date: 2026-06-03

Original recommendation

P3 — Prune duplicated auth-mode wording/tests: keep one source of truth for auth mode semantics and use route-level tests for high-risk flows.

Matched top finding

README says browser mutating API calls automatically include Basic Auth credentials via authedFetch(), and some board paths do. Other active UI paths still use plain fetch() for protected mutating routes, which means DISPATCH_AUTH_MODE=basic operators can hit 401s or inconsistent behavior depending on page/component.

Evidence:

  • src/lib/client-auth.ts defines authedFetch() and sessionStorage-backed Basic Auth header injection.
  • src/components/sync-issues-button.tsx:6,35 and src/components/kanban-board.tsx:26,89,118,213 use authedFetch.
  • src/app/automation/page.tsx:198,212,239, src/app/automation/repos/[...repo]/page.tsx:297, and src/components/issue-card.tsx:96,119,148,194 still use plain fetch for protected POST/DELETE routes.
  • Static scan command: grep -RIn "fetch(" src/app src/components showed the split.

Activity

  1. added
    auditAudit, review, or investigation work.
    status/backlogNot ready for worker pickup yet.
    status/readyReady for Dispatch worker pickup.
    and removed
    status/backlogNot ready for worker pickup yet.
    on Jun 4, 2026
  2. itsmiso-ai commented on Jun 5, 2026

    @itsmiso-ai
    ContributorAuthor

    Saffron grooming result: promoted to ready

    P3 concrete fix: prune duplicated auth-mode wording/tests, keep one source of truth for auth mode semantics. Clear scope.

  3. added
    status/in-reviewPull request or human review is in progress.
    and removed
    status/readyReady for Dispatch worker pickup.
    on Jun 10, 2026
  4. added and removed
    status/in-reviewPull request or human review is in progress.
    on Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    auditAudit, review, or investigation work.status/doneWork is complete.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions