Skip to content

Add operational runbook notes for DISPATCHAUTHMODE=disabled #320

Closed

Description

@itsmiso-ai

Parent umbrella issue: #308
Source audit: Weekly tech debt audit: dispatch - 2026-06-03
Source audit date: 2026-06-03

Original recommendation

P3 — Add operational runbook notes for DISPATCH_AUTH_MODE=disabled: keep it explicitly local-only and add deployment checks if feasible.

Matched top finding

The pull-based PR follow-up sync endpoint is a mutating POST that does not use the shared authorizeRequest() helper. The webhook endpoint can intentionally skip signature verification when WEBHOOK_SECRET is unset, which may be acceptable behind a gateway but is risky as a default unless deployment docs and runtime checks make that explicit.

Evidence:

  • Mutating routes without authorizeRequest scan returned: src/app/api/auth/logout/route.ts, src/app/api/pr-followup/sync/route.ts, src/app/api/pr-followup/webhook/route.ts.
  • src/app/api/pr-followup/sync/route.ts:88 exports POST() and scans tracked repos using GITHUB_TOKEN without a route auth check.
  • src/app/api/pr-followup/webhook/route.ts:186-196 verifies signatures only if WEBHOOK_SECRET is configured.
  • src/app/api/pr-followup/webhook/route.ts:222 persists queue work through processPrFollowupEvents(...).

Activity

  1. added
    auditAudit, review, or investigation work.
    status/backlogNot ready for worker pickup yet.
    on Jun 4, 2026
  2. itsmiso-ai commented on Jun 5, 2026

    @itsmiso-ai
    ContributorAuthor

    Saffron grooming result: kept in backlog — needs human decision

    P3 security policy on DISPATCH_AUTH_MODE=disabled. Mutating POST without auth is risky — need design decision before ops runbook can be written.

  3. added
    status/readyReady for Dispatch worker pickup.
    status/in-reviewPull request or human review is in progress.
    and removed
    status/backlogNot ready for worker pickup yet.
    status/readyReady for Dispatch worker pickup.
    on Jun 5, 2026
  4. added and removed
    status/in-reviewPull request or human review is in progress.
    on Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    auditAudit, review, or investigation work.status/doneWork is complete.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions