Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
|
@panyam would you be willing to give this one a review? |
|
Hey @pcarleton and @1fanwang very sorry about the late one. Went through it. Thanks heaps for this. Left a couple of (minor) comments. Also added a live SDK run results. Branch merged onto
Nice to see 2 independent implementations satisfy the new check, both going from 9 to 10 green. I could not find task support in the official Go SDK, and its run is what the inline note above is about (did I miss something). Also, the branch is based on |
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
|
Thanks for the quick turn around @1fanwang - Ran it against the new head and both emit now. LGTM. @pcarleton good from my side. |
Motivation and Context
The
tasks-lifecyclereport omitted its cancelled-status check when task creation or polling failed. It also accepted a completed status for the cancellable fixture. The check now requires that fixture's cancelled status and reports missing prerequisites as failures. MCP cancellation remains cooperative.Closes #485.
How Has This Been Tested?
On Node 22.17.0, the lifecycle regressions drive the real runner against local HTTP task fixtures. They require SUCCESS for cancelled, FAILURE for completed/failed, and an untestable failure for missing tasks or polling timeouts.
Before: 7169291. After: this PR's head. The dependency manifests are identical.
Raw log excerpts
Before, completed fixture:
After, including both cancelled and completed assertions:
Breaking Changes
None. Missing prerequisites now appear as a failure row.
Types of changes
Checklist
Additional context
These fixtures are not an independent task-capable SDK.
AI disclosure: GitHub Copilot CLI wrote this change and its tests, and an automated coordinator reviewed the diff and test output before submission.