Skip to content

Write "event: message" to SSE response - #192

Merged
halter73 merged 6 commits into
modelcontextprotocol:mainfrom
halter73:sse-message
Apr 2, 2025
Merged

halter73 merged 6 commits into
modelcontextprotocol:mainfrom
halter73:sse-message

Conversation

@halter73

@halter73 halter73 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Even though this wastes a few more bytes per message in the SSE response stream, this appears to be the way to send SSE message events that's most compatible with existing MCP clients.

I also took the opportunity to rename McpJsonRpcEndpoint to just McpEndpoint. I wanted to do that in my earlier refactoring PR that split a lot of it out into McpSession, but I was trying to keep that change as small as I could. I don't think it's worth a whole PR just to rename it now though.

Lastly, I removed the unused McpServerConfig.Arguments property. Arguments are now passed in via McpServerConfig.TransportOptions["arguments"] instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants