Skip to content

feat: Add Support for mkdocs - #883

Merged
maciej-kisiel merged 1 commit into
modelcontextprotocol:mainfrom
Dinesht04:main
Apr 9, 2026
Merged

maciej-kisiel merged 1 commit into
modelcontextprotocol:mainfrom
Dinesht04:main

Conversation

@Dinesht04

@Dinesht04 Dinesht04 commented Apr 7, 2026 •

Copy link
Copy Markdown
Contributor

Affects /docs - (Refined Documentation for deployment and added Some Supporting documentation)
Added a github action for deployment

Fixes #835

Added Support for mkdocs
Example - https://dinesht04.github.io/go-sdk/

Requires Configuration of Github pages as follows:-

  1. Enable Github Pages
  2. Select gh-pages branch for deployment
gh-pages

Sources

For mkdocs.yaml

  1. https://github.com/modelcontextprotocol/python-sdk/blob/main/mkdocs.yml
  2. https://github.com/modelcontextprotocol/java-sdk/blob/main/mkdocs.yml
  3. MKDocs official documentation

For Github Action

  1. https://github.com/modelcontextprotocol/python-sdk/blob/main/.github/workflows/publish-docs-manually.yml
  2. https://github.com/modelcontextprotocol/java-sdk/blob/main/.github/workflows/docs.yml
  3. https://github.com/james-willett/material-mkdocs-youtube-2024/blob/main/.github/workflows/ci.yml - From Youtube Tutorial

Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread docs/quick_start.md
Comment thread docs/quick_start.md
Comment thread docs/README.md
Comment thread mkdocs.yaml Outdated
Comment thread mkdocs.yaml
@jba

jba commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

nit: we don't use the feat|chore|... prefix in our commit messages.

@Dinesht04

Copy link
Copy Markdown
Contributor Author

Hey, I'm actually a little confused, I think I messed up something while force pushing my changes and the latest changes aren't reflecting 😅 . Looking into it right now

@Dinesht04
Dinesht04 force-pushed the main branch 2 times, most recently from 2437257 to fcdbba8 Compare April 8, 2026 12:10
@Dinesht04
Dinesht04 marked this pull request as ready for review April 8, 2026 12:10
@Dinesht04

Copy link
Copy Markdown
Contributor Author

hey @maciej-kisiel , followed up on your suggestions and updated the code ^_^

@maciej-kisiel maciej-kisiel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you apply the changes, could you re-deploy the docs to the link in your description?

Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread .github/workflows/publish-docs.yml Outdated
Comment thread internal/docs/contributing.src.md Outdated
Comment thread internal/docs/protocol.src.md Outdated
@maciej-kisiel

maciej-kisiel commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

nit: we don't use the feat|chore|... prefix in our commit messages.

@jba I am guilty of that as well.. Sometimes I put "chore:" when there is no clear Go package that is changed, e.g. when I'm just modifying GitHub Actions configuration. Do you have a suggestion for a better prefix in such cases?

@jba

jba commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

We use the package ("oathex: frob widgets") or the file ("go.mod: update to 1.26") or sometimes nothing, if it's hard to describe the scope.

@Dinesht04

Copy link
Copy Markdown
Contributor Author

hey @maciej-kisiel here are the deployed docs with the latest changes
https://dinesht04.github.io/go-sdk/

Also, I included a contributing.src.md in internal/docs to pass the doc-check test which includes the pymarkdown snippet.
the doc-check matches the /docs directory from what files would have been generated in internal/docs when go generate would have been executed.

@maciej-kisiel
maciej-kisiel merged commit 1209861 into modelcontextprotocol:main Apr 9, 2026
10 checks passed
maciej-kisiel pushed a commit that referenced this pull request Apr 9, 2026
Affects /docs - (Refined Documentation for deployment and added Some
Supporting documentation)
Added a github action for deployment

Fixes #835

Added Support for mkdocs
Example -  https://dinesht04.github.io/go-sdk/

Requires Configuration of Github pages as follows:-

1. Enable Github Pages
2. Select gh-pages branch for deployment

<img width="1237" height="817" alt="gh-pages"
src="https://github.com/user-attachments/assets/01f0b012-d5f3-4011-9af9-7269e657ae6a"
/>

1.
https://github.com/modelcontextprotocol/python-sdk/blob/main/mkdocs.yml
2. https://github.com/modelcontextprotocol/java-sdk/blob/main/mkdocs.yml
  3. MKDocs official documentation
1.
https://github.com/modelcontextprotocol/python-sdk/blob/main/.github/workflows/publish-docs-manually.yml
2.
https://github.com/modelcontextprotocol/java-sdk/blob/main/.github/workflows/docs.yml
3.
https://github.com/james-willett/material-mkdocs-youtube-2024/blob/main/.github/workflows/ci.yml
- From Youtube Tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure mkdocs to serve the user documentation

3 participants