Skip to content

extract listpane - #12

Merged
ashwin-ant merged 2 commits into
mainfrom
ashwin/listpane
Oct 9, 2024
Merged

ashwin-ant merged 2 commits into
mainfrom
ashwin/listpane

Conversation

@ashwin-ant

@ashwin-ant ashwin-ant commented Oct 8, 2024 •

Copy link
Copy Markdown
Member

Stacked on #11

Review in this order:

  1. add readme #6
  2. add command history #8
  3. resource refreshing #9
  4. make prompts pass args #10
  5. get tools working #11
  6. extract listpane #12

See #12 for demo video.

Demo of stack:

CleanShot.2024-10-08.at.16.52.06.mp4

@jspahrsummers jspahrsummers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

Base automatically changed from ashwin/tools to main October 9, 2024 16:05
@ashwin-ant
ashwin-ant merged commit 20a2dbe into main Oct 9, 2024
@ashwin-ant
ashwin-ant deleted the ashwin/listpane branch October 9, 2024 16:06
ashwin-ant added a commit that referenced this pull request Oct 15, 2024
dcc30be Merge pull request #16 from modelcontextprotocol/ashwin/protocol
05a3e54 fix protocol version in client
73c66f4 Merge pull request #13 from modelcontextprotocol/justin/uris
5cad4b5 Merge pull request #12 from modelcontextprotocol/justin/spec-updates
ec96ffc Treat URIs as 'URL' type
f3a8fb8 yarn build
69daade Update to latest protocol version

git-subtree-dir: packages/mcp-typescript
git-subtree-split: dcc30bea4904b04c50d858f6a369d3015920fab2
cliffhall added a commit that referenced this pull request Sep 30, 2026
…older (Copilot)

- The body-reference extraction did scan(...)[] | .[0], which with gh's
  jq indexes the first CHARACTER of each captured string: "Closes #2554"
  became issue 2. It is now scan(...) | .[0]. Verified with gh --jq:
  "Closes #2554 … Fixes #12 … resolves #999" gave [2,1,9] before and
  [2554,12,999] after. The 2.9.0 check missed it because every PR there
  also carried a manual closing link.
- <assembled-notes.md> inside a shell block is input redirection, so
  --notes-file lost its argument. It is now a NOTES variable.

Cross-checked: the fixed recipe reproduces the published Thanks lists
of 2.9.0, 2.8.0, 2.5.0 and 2.4.0 exactly (26 reporters; three of those
lists were built independently).

Refs #2554

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants