fix(client): stop an inherited PATH from shadowing an explicit Path o… - #2900
Draft
liwenjie200543 wants to merge 1 commit into
Draft
liwenjie200543 wants to merge 1 commit into
liwenjie200543 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 394b991 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
StdioClientTransport.start()merged the default environment with the caller'senvby plain spread. On Windows that produces a spawn env containing both the inheritedPATH(fromgetDefaultEnvironment()) and the caller'sPathwhen the caller spells it that way. Windows resolves environment variables case-insensitively, the inherited entry wins, and the caller's explicit value is silently discarded (issue #2859, where an explicitPathnever reaches the server process).Change
mergeSpawnEnvnow drops inherited entries that differ from an override only in casing, so the caller's entry is the single value the child sees, with the casing the caller chose. On POSIX,PATHandPathare distinct variables and both survive — the platform flag is a parameter, so tests pin both modes without touchingprocess.platform.Verification
node -e "process.stdout.write(process.env.Path ?? process.env.PATH)"with an env merged the old way prints the inherited value; merged the new way it prints the caller's value.packages/client/test/client/stdioEnvCase.test.ts: merge semantics for case-insensitive and case-sensitive modes, plus a transport-level test asserting the spawned env keeps the caller'sPath. The transport test fails against the old spread on Windows (verified by stashing the fix).pnpm vitest runinpackages/client: 921 passed, 2 skipped.tsgotypecheck, eslint and prettier clean on the touched files.Fixes #2859