Repository navigation
Fix URI template optional query matching - #2909
Open
gauravch-code wants to merge 2 commits into
Open
gauravch-code wants to merge 2 commits into
gauravch-code wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 471d036 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
UriTemplate.match()for query templates whose query parameters are optional or appear in a different order than the template declaration.Before this change, a template like:
dom://{pageId}{?selector,includeAttributes,includeText,includeChildren}could fail to match a URI with no query string, or a URI where only some query parameters are present. The path variable could also consume
?because simple/path match groups did not stop at query or fragment delimiters.This change:
?,,,#, and/as appropriate;Fixes #1079.
Validation
Ran the focused URI template test file:
Result:
41 passed.Ran package typecheck:
Result: passed.
Ran ESLint on the touched source file and Prettier check on the touched files:
Result: passed.