fix(uri-template): preserve percent-encoded triplets in reserved expansions - #2923
Draft
takagibit18 wants to merge 1 commit into
Draft
takagibit18 wants to merge 1 commit into
takagibit18 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d7d4888 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserved and fragment expansions currently turn
%20into%2520, changing a value that already contains a URI escape. Preserve valid%HHsequences afterencodeURI()for those two operators.The behavior follows RFC 6570 section 3.2.1. Regression tests cover lowercase hex digits, encoded percent signs, list elements, fragment values and malformed escapes. A simple-expansion test checks that its percent sign is still encoded. The changeset covers the client and server packages, which publicly export
UriTemplate.Closes #2920.
Validation
--configLoader runner.pnpm lint:all,pnpm typecheck:all, andpnpm build:all: passed.The full workspace test run on Windows has failures in the codemod symlink-cycle test and two stdio shutdown-escalation cases that wait for a SIGTERM marker.