Repository navigation
feat(ui): select exact diff lines with mouse - #840
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR makes mouse gestures select the exact rendered diff line and split side using OpenTUI’s painted viewport coordinates while preserving deliberate copy gestures and nested control ownership.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issue identified. The mouse-selection changes preserve deliberate and expanded copy gestures, use painted viewport geometry for scrolled hit testing, isolate nested controls, and include focused coverage for the principal interaction paths. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Mouse press on diff row] --> B[Resolve painted viewport point]
B --> C{Nested row control?}
C -->|Yes| D[Run nested action only]
C -->|No| E{Click or one-cell jitter?}
E -->|Yes| F[Resolve row bounds and split side]
F --> G[Select semantic line cursor]
E -->|No| H[Normalize deliberate drag range]
H --> I[Copy rendered selection]
Reviews (1): Last reviewed commit: "feat(ui): select exact diff lines with m..." | Re-trigger Greptile |
benvinegar
force-pushed
the
feat/mouse-line-selection
branch
from
August 25, 2026 01:26
031c55e to
7b682ef
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cursor-line offcopy behavior[+]affordance so it only opens the note composerTesting
bun run typecheckbun run lintbun run deps:checkbunx oxfmt --checkon changed filesENOEXECspawn failure passed on focused rerun after removing a shadowingnode_modules/.bin/bunleft by dependency repairLocal environment note
bun test: 3241 passed and 19 skipped; the remaining failures/errors come from the globally installedhunk-lensextension being discovered by the local test runThis PR description was generated by Pi using OpenAI Codex gpt-5.6-sol