Repository navigation
Fix #721, https://github.com/mozilla/thimble.mozilla.org/issues/2005: bramble.less - #735
Merged
Merged
Conversation
Author
|
@flukeout can you review please? |
|
Hey @humphd pulled this branch then ran
Did I test it correctly, any steps I missed? |
flukeout
suggested changes
Apr 20, 2017
flukeout
left a comment
There was a problem hiding this comment.
I don't think it's working correctly. See my comment.
|
Disregard comment, didnt have my dev tools open so it was cached. Works as expected. |
flukeout
approved these changes
Apr 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes our load ordering for LESS/CSS, such that our overrides get added in the proper order (i.e., last). It also continues to have us use a single file for fewer requests.
NOTE: all Brackets CSS/LESS should still go in
bramble_overrides.less