Repository navigation
Fetch report from Clouseau in batches - #243
Merged
Merged
Conversation
marco-c
approved these changes
Jul 17, 2024
Collaborator
|
|
Member
Author
This requires Python >= 3.12: https://docs.python.org/3/library/itertools.html#itertools.batched I coped with the implementation in 27a9a8d to avoid compatibility issues. We could drop that once we drop the support for Python < 3.12. |
marco-c
reviewed
Jul 17, 2024
Comment on lines
+387
to
+388
| # This is a roughly equivalent to the itertools.islice which was added in | ||
| # Python 3.10. |
Collaborator
There was a problem hiding this comment.
What if we just require 3.10?
Member
Author
There was a problem hiding this comment.
I prefer that. We need first to update Taskcluster to run on Python 3.10 instead of Python 3.9.
I filed an issue for that since it is out of the scope of this PR: #245
marco-c
reviewed
Jul 17, 2024
marco-c
reviewed
Jul 17, 2024
marco-c
approved these changes
Jul 17, 2024
Co-authored-by: Marco Castelluccio <mcastelluccio@mozilla.com>
Co-authored-by: Marco Castelluccio <mcastelluccio@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/bugbot#2445