Authenticate the Codecov upload with OIDC - #34
Merged
Merged
Conversation
The upload carried a CODECOV_TOKEN secret. The repository is public, so there is nothing that token protects that the run's own identity does not, and it is one less secret to hold and rotate. The action mints a GitHub OIDC token instead, which is what id-token: write on the job is for. A pull request from a fork reaches neither the secret nor OIDC, and uploads without either one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 38 38
Lines 1685 1685
=======================================
Hits 1397 1397
Misses 288 288 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secrets.CODECOV_TOKENis replaced by an OIDC token the run mints for itself. The repository is public, so there is nothing the stored token protects that the run's own identity does not, and it is one less secret to hold and rotate.id-token: writeon thetestjob,use_oidc: trueon the upload, and the stored token goneVerified on mpyw/go-skill-embed and mpyw/declscope first: the OIDC upload landed, and Codecov activated both repositories on its own.
Once this is green,
CODECOV_TOKENcan be deleted from the repository secrets.🤖 Generated with Claude Code