Skip to content

MessagePacker should use byte[] based buffer allocator  #116

Closed

Description

@xerial

https://github.com/msgpack/msgpack-java/blob/v07-value2/msgpack-core/src/main/java/org/msgpack/core/MessagePacker.java#L86-86

This code should use MessageBuffer.newBuffer instead of MessageBuffer.newDirectBuffer because DirectByteBuffer is an off-heap memory and should be used carefully. For example, the default maximum size of DirectByteBuffer is usually limited to several MBs. It might cause OutOfMemoryException.

Activity

  1. added this to the v07 milestone on Jul 11, 2014
  2. added a commit that references this issue on Jul 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions