Repository navigation
protect stack size even further - #90
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 16 16
Lines 962 962
Branches 196 196
=======================================
Hits 946 946
Misses 16 16
Continue to review full report at Codecov.
|
Member
|
I think the available stack size varies in browsers, but yes the current size is too big. Thanks for your efforts. |
Member
|
Released as v1.9.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Sorry to touch this same area again! Turns out my previous fix wasn't enough for most use cases. In isolation reducing it by
4was enough to pass tests but if your code is running on any kind of stack itself you'll run out of stack space. Looking at what some other projects do it seems pretty popular to just change this value to give yourself some headroom (like: https://github.com/feross/buffer/blob/master/index.js#L1023)