Repository navigation
Strings cleaner > fix stop name length (default zoom) - #32
Merged
Merged
Conversation
Also, apply clean bounds only it still too long
ghost
marked this pull request as ready for review
April 22, 2026 18:49
left a comment
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the StringsCleaner utility by introducing a shortMaxLength parameter to the cleanString function and increasing the STOP_NAME_SHORT_MAX_LENGTH from 17 to 27. These changes allow for more precise control over string shortening logic. Feedback suggests improving consistency across cleaning methods by applying CleanUtils.cleanSlashes to route long names and stop names if they still exceed their maximum length after the initial cleaning process, matching the existing behavior for trip headsigns.
ghost
deleted the
mm/strings_cleaner_stop_name_longer
branch
April 22, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, apply clean bounds only it still too long