Skip to content

CI: Test NUT_SSL_CLIENT_VALIDATION_VARIANTS in the build matrix - #3640

Merged
jimklimov merged 8 commits into
networkupstools:masterfrom
jimklimov:issue-3329
Oct 14, 2026
Merged

jimklimov merged 8 commits into
networkupstools:masterfrom
jimklimov:issue-3329

Conversation

@jimklimov

@jimklimov jimklimov commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Follow-up for #1711 and #3329

Now that client validation is possible with both NSS and OpenSSL, and NIT can set up client and server certificates for testing, extend BUILD_TYPE=default-all-errors* handling with both variants here.

When this is quick-matrixed, it should sub-variate for non-trivial SSL backends (openssl/nss specifically, or yes/auto lacking those specifics).

@jimklimov jimklimov added this to the 2.8.6 milestone Sep 11, 2026
@jimklimov jimklimov added the CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) label Sep 11, 2026
@jimklimov jimklimov added this to NUT QA Sep 11, 2026
@jimklimov jimklimov added the SSL/NSS Issues and PRs about SSL, TLS and other crypto-related matters label Sep 11, 2026
@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

A ZIP file with standard source tarball and another tarball with pre-built docs for commit 1aed827 is temporarily available: NUT-tarballs-PR-3640.zip.

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

✅ Build nut 2.8.5.5282-master completed (commit 7688895105 by @jimklimov)

@AppVeyorBot

Copy link
Copy Markdown

✅ Build nut 2.8.5.5283-master completed (commit 84c817cf51 by @jimklimov)

@jimklimov jimklimov moved this to In Progress in NUT QA Sep 14, 2026
jimklimov added a commit to jimklimov/nut that referenced this pull request Sep 14, 2026
Comment thread tests/test_upsdconf.c Dismissed
Comment thread tests/test_upsdconf.c Dismissed
@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

✅ Build nut 2.8.5.5318-master completed (commit c8534a35b1 by @jimklimov)

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

✅ Build nut 2.8.5.5319-master completed (commit 379419181b by @jimklimov)

@jimklimov

jimklimov commented Sep 15, 2026 •

Copy link
Copy Markdown
Member Author

Ubuntu Trusty (14.04) - uncommon OpenSSL antiqueness that did not backfire elsewhere:

../../server/netssl.c: In function 'openssl_cert_verify_callback':
../../server/netssl.c:406:24: error: 'X509_V_ERR_HOSTNAME_MISMATCH' undeclared (first use in this function)
   if (san_ok && err == X509_V_ERR_HOSTNAME_MISMATCH) {
                        ^
../../server/netssl.c:406:24: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [upsd-netssl.o] Error 1

Probably warrants a configure.ac test and/or a label-gate for ci_build.sh...

UPDATE: nah, an old ifdef may cut it here.

jimklimov added a commit to jimklimov/nut that referenced this pull request Sep 18, 2026
@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

jimklimov added a commit to jimklimov/nut that referenced this pull request Sep 23, 2026
jimklimov added a commit to jimklimov/nut that referenced this pull request Sep 23, 2026
@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

…nly [networkupstools#3329]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…BUILD_TYPE=default-all-errors* [networkupstools#3329, networkupstools#1711]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…* non-trivial NUT_SSL_VARIANT builds [networkupstools#3329, networkupstools#1711]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Some macros in OpenSSL on certain platforms resolve to always-true
at compile time, so embedded conditionals are pointless.
Not much we can do about them though.

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@AppVeyorBot

Copy link
Copy Markdown

✅ Build nut 2.8.5.5627-master completed (commit 02a9171db5 by @jimklimov)

@jimklimov
jimklimov merged commit d85ca8a into networkupstools:master Oct 14, 2026
125 of 136 checks passed
@jimklimov
jimklimov deleted the issue-3329 branch October 14, 2026 20:17
@jimklimov jimklimov moved this from In Progress to Done in NUT QA Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) SSL/NSS Issues and PRs about SSL, TLS and other crypto-related matters

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants