Skip to content

[Bug] setValueByKey function is no longer exported in version 0.12.0 #398 - #399

Merged
nev21 merged 1 commit into
mainfrom
nev21/PrepareRelease
Apr 14, 2025
Merged

nev21 merged 1 commit into
mainfrom
nev21/PrepareRelease

Conversation

@nev21

@nev21 nev21 commented Apr 14, 2025

Copy link
Copy Markdown
Contributor
  • re-export the dropped functions due to code restructuring

@nev21 nev21 added this to the 0.12.1 milestone Apr 14, 2025
Copilot AI review requested due to automatic review settings April 14, 2025 14:29
@nev21
nev21 requested a review from a team as a code owner April 14, 2025 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

lib/src/index.ts:48

  • Ensure that the re-exported functions are fully compatible with all dependent modules after the restructuring. If any interfaces have changed, adjustments may be needed across the codebase.
export { getValueByKey, setValueByKey, getValueByIter, setValueByIter } from "./helpers/get_set_value";

lib/src/index.ts:133

  • Add or update tests to verify the behavior of polyObjHasOwn, ensuring that the functionality remains consistent following the re-export.
export { polyObjHasOwn } from "./polyfills/object/objHasOwn";

@codecov

codecov Bot commented Apr 14, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (21a2fb2) to head (8f5c7d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         115      115           
  Lines        2946     2946           
  Branches      604      604           
=======================================
  Hits         2879     2879           
  Misses         67       67           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…398

- re-export the dropped functions due to code restructuring
@nev21
nev21 force-pushed the nev21/PrepareRelease branch from 65ecc7d to 8f5c7d4 Compare April 14, 2025 14:40
@nev21
nev21 merged commit 8619fd0 into main Apr 14, 2025
@nev21
nev21 deleted the nev21/PrepareRelease branch April 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants