Repository navigation
Increase code coverage - #412
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to increase code coverage by adding tests for the number helper functions while also refactoring several polyfill modules to use a consolidated internal implementation. Key changes include:
- Adding comprehensive tests for the getIntValue function.
- Updating import paths in polyfill modules (objIsSealed, objIsFrozen, etc.) to use the new consolidated get_own_property APIs.
- Removing deprecated polyfill files and re-exporting consolidated implementations in the lib/src/index.ts file.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/test/src/common/helpers/number.test.ts | Added tests to increase coverage for getIntValue and related helpers. |
| lib/src/helpers/number.ts | Updated getIntValue to use asString conversion and a try/catch block. |
| lib/src/polyfills/object/objIsSealed.ts & objIsFrozen.ts | Updated import paths to reference the new get_own_property module. |
| lib/src/object/has_own.ts & lib/src/object/define.ts | Refactored internal helper usages to align with the new unified API. |
| lib/src/internal/* and other get_own_property* files | Removed deprecated files and consolidated various object helper APIs. |
Comments suppressed due to low confidence (1)
lib/src/object/define.ts:270
- [nitpick] The use of the internal helper _objGetOwnPropertySymbols is a change from the previous naming. Please ensure that this naming convention is applied consistently across similar helper functions.
arrForEach(_objGetOwnPropertySymbols(propDescMap), (sym) => {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 97.50% 98.92% +1.42%
==========================================
Files 114 110 -4
Lines 2887 2893 +6
Branches 586 608 +22
==========================================
+ Hits 2815 2862 +47
+ Misses 72 31 -41
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.