Repository navigation
Add setGlobalTimeoutOverrides - #416
Merged
Merged
Conversation
- Also updates readme link check to identify missed functions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a global timeout override mechanism with the new function setGlobalTimeoutOverrides and extends the tests to ensure its proper behavior while also updating the README link check to include additional functions.
- Added tests in timeout.test.ts for global timeout override functionality.
- Updated the exports in index.ts and the implementation in timeout.ts to support the new functionality.
- Updated readme-links-check.js and bundle-size-check.js as per the new documentation and bundle size limits.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/test/src/common/timer/timeout.test.ts | Added test suites to validate global timeout override behavior |
| lib/test/readme-links-check.js | Updated logic to filter and display unlinked documentation files |
| lib/test/bundle-size-check.js | Adjusted bundle size limits as per new thresholds |
| lib/src/timer/timeout.ts | Introduced global override functions and integrated them in timeout APIs |
| lib/src/index.ts | Updated exports to include the new setGlobalTimeoutOverrides function |
| README.md | Updated documentation to reflect the new timeout override functionality |
Comments suppressed due to low confidence (1)
lib/test/src/common/timer/timeout.test.ts:886
- [nitpick] Consider renaming the loop variable 'lp' to a more descriptive identifier (e.g. 'i' or 'tick') to improve code readability.
for (let lp = 0; lp < 99; lp++) {
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 98.92% 98.85% -0.07%
==========================================
Files 108 108
Lines 2879 2890 +11
Branches 606 591 -15
==========================================
+ Hits 2848 2857 +9
- Misses 31 33 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a global timeout override mechanism with the new function setGlobalTimeoutOverrides and extends the tests to ensure its proper behavior while also updating the README link check to include additional functions.