Skip to content

No edit on shared links on files #3922

Closed

Description

@tobiasKaminsky

2019-04-18-080018 2019-04-18-080003

On left (file) edit icon is missing.
This is due to:

private void setLinkDetailVisible(boolean visible) {
if (visible) {
if (file.isFolder()) {
shareByLinkAllowEditing.setVisibility(View.VISIBLE);
} else {
shareByLinkAllowEditing.setVisibility(View.INVISIBLE);
}
overflowMenuShareLink.setVisibility(View.VISIBLE);
} else {
shareByLinkAllowEditing.setVisibility(View.INVISIBLE);
overflowMenuShareLink.setVisibility(View.INVISIBLE);
}
}

@AndyScherzinger as you changed it (no blame :-)), do you remember why you did this?

Activity

  1. tobiasKaminsky commented on Apr 18, 2019

    @tobiasKaminsky
    MemberAuthor

    Now I know why.
    When enabling via android, I do get "public upload is only possible for public shared folders".

  2. AndyScherzinger commented on Apr 18, 2019

    @AndyScherzinger
    Member

    Erm, I think I did this because I thought that there is no edit option on files shared by link.

  3. tobiasKaminsky commented on Apr 18, 2019

    @tobiasKaminsky
    MemberAuthor

    At least on NC16 in web ui there is.
    I'll figure this out and fix it :-)

  4. AndyScherzinger commented on Apr 18, 2019

    @AndyScherzinger
    Member

    Thanks a lot 😊👍

  5. tobiasKaminsky commented on Apr 18, 2019

    @tobiasKaminsky
    MemberAuthor

    Sooner or later we have to do this

    • reflect all settings / layout like web ui
    • allow multiple share links
    • clean up
    • add test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions