Repository navigation
Conversation
Rename the app from 'Nextcloud Office (Collabora)' to 'Collabora Online' across user-facing strings, settings sections, notifications, task processing providers and docs. The notification source name now uses the product name instead of a hardcoded 'Office' label, and the settings section heading no longer branches on the Collabora product version check. Assisted-by: OhMyPi:qwen3.8-27b Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com>
After the rename the admin description read 'Collabora Online requires a
separate server running Collabora Online', immediately next to a second
sentence saying the same thing more precisely. Drop the redundant one and
keep the WOPI-like Client wording, which is unchanged and keeps its
translations.
The product description branched on hasNextcloudBranding purely to pick a
name, so both arms became the same sentence. Collapse them and resolve the
name through the {productName} placeholder, which also stops the paragraph
contradicting the heading above it on a white-label install. That was the
last consumer of the hasNextcloudBranding initial state in this component.
Personal settings hardcoded the name while its surrounding section heading
resolves getProductName(), so a white-label install showed the vendor name
outside the panel and 'Collabora Online' inside. Read the product name the
same way the admin settings already do.
Notifier::getName() was a constant before this branch and now reads the
cached capabilities, which touches app data. Fall back rather than let a
display label break the notifier list.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com>
The literal substitution left two wrong sentences on the repo front page. README.md said "Collabora Online is built on Collabora Online", which only parsed while the subject and object were different names, and it claimed Collabora Online is based on CODE when CODE is an edition of Collabora Online, not the other way round. Rewrite both around the app rather than the product. docs/frontend-integration.md had the same problem in the sentence that exists to separate the emitting server from the handling app. Drop hasNextcloudBranding(): this branch removed its last consumer, and what remained was an initial state nothing read and a product-version check nothing called. Stop sending the product name through gettext. A brand is not a translatable string, and this was the last use of IL10N in the class. Expose it as a constant so the notifier fallback cannot drift from it, and log the swallowed failure instead of discarding it silently. Cover the two behaviour changes: that getProductName() resolves a white-label vendor name, which the old hardcoded 'Office' made unreachable; that the settings section no longer branches on the product version; and that the notifier falls back rather than propagating when the capabilities lookup throws, which nothing exercised before. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com>
7 tasks
Contributor
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Collabora integration from "Nextcloud Office (Collabora)" to
"Collabora Online" throughout the user-facing surface. The appstore listing
is generated from
<name>inappinfo/info.xmlat release time, so thatline is what updates the store entry.
"Nextcloud Office" is now the name of the Euro-Office based suite, so
keeping it on this app made the two products ambiguous wherever they appear
side by side.
Behaviour changes
Two changes here are more than string replacement and deserve a closer look:
lib/Settings/Section.php— removed thehasNextcloudBranding()branchin
getName(); it now returnsgetProductName()unconditionally, and thethen-unused
IL10Ndependency is gone.hasNextcloudBranding()is aCollabora product version check (
isVersionAtLeast('21.11')), not a themecheck, so the old branch meant a default install showed a bare "Office".
Effects: default install now shows "Collabora Online"; a white-label install
(app setting
theme !== 'nextcloud'plus a vendorproductNameincapabilities) now reaches the vendor's own name, which was previously
unreachable.
lib/Notification/Notifier.php—getName()returned a hardcoded'Office'and now returns the product name. Since that call reaches thecached capabilities and therefore touches app data, where it used to be a
constant, it falls back rather than letting a display label break the
notifier list.
Both classes are type-wired (
info.xmlandregisterNotifierService());there are no positional constructions to update.
The admin and personal settings now resolve the product name the same way,
so a white-label install no longer shows the vendor name on a section
heading and "Collabora Online" inside the panel.
Out of scope
CHANGELOG.mdandl10n/*.jsare untouched — translations are regeneratedby the pipeline. The
OfficeVue component name is internal, notuser-facing. The
onlyofficeapp is a separate product and unaffected.Note on translations
The changed
t()source strings lose their existing translations untilTransifex catches up. This will apply to the backports as well.
Testing
Assisted-by: ClaudeCode:opus-5