[master] Consistent sharing acceptance test failure

Steps

Send a PR with any kind of changes to master
Wait for CI
💥

Expected

No 💥

Actual

💥

The test /drone/src/tests/acceptance/features/app-files-sharing.feature:23 always fails.

    And I accept the share for "/farewell.txt" in the notifications           # NotificationsContext::iAcceptTheShareForInTheNotifications()
      Notifications button in the header could not be found after 100 seconds (NoSuchElementException)
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()

Running the test locally makes it pass.

So could be either a timeout issue or something specific to the CI setup.

Last successful build on master: https://drone.nextcloud.com/nextcloud/server/3568

Then something about php8 didn't run at all: https://drone.nextcloud.com/nextcloud/server/3574

Then the first failure appeared here: https://drone.nextcloud.com/nextcloud/server/3598/61/4

Reproducible locally now when running that single acceptance test on master a75f0e6 and notifications 3410e5ab517f8435ab2cfd80549d43fbbfb41b1f

okay, getting this with manual test:

very likely related to nextcloud/notifications#899

Fix is here: nextcloud/notifications#902

It's still happening on master, for example this recent merge PR https://drone.nextcloud.com/nextcloud/server/4104/61/4 and also existing (rebased) PR: #25320

A manual test on the master branch of server + master branch of notifications, clicking through the GUI works fine, the notification appears.

However, running ./run.sh features/app-files-sharing.feature:23 in the "tests/acceptance" folder fails.

@danxuliu

as discussed with @danxuliu, the Firefox version in the dockers and selenium are outdated and unsupported.

the error is caused by a syntax error, probably due to Babel not transpiling for such old versions

this PR #25991 updates Selenium and should fix the problem

this PR #25991 updates Selenium and should fix the problem

For the record, I actually checked it and it indeed works.

Rebased 25991, let's get this in as soon as we can :)

Thank you for all the hard work on upgrading selenium :)

#25991 was merged, so the failure is gone :-)

Navigation Menu

Repository navigation

[master] Consistent sharing acceptance test failure #26314

Steps

Expected

Actual

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[master] Consistent sharing acceptance test failure #26314

Description

Steps

Expected

Actual

Activity

PVince81 commented on Mar 26, 2021

PVince81 commented on Mar 26, 2021

PVince81 commented on Mar 26, 2021

PVince81 commented on Mar 26, 2021

PVince81 commented on Mar 26, 2021

PVince81 commented on Apr 12, 2021

PVince81 commented on Apr 12, 2021

PVince81 commented on Apr 12, 2021

danxuliu commented on Apr 12, 2021

skjnldsv commented on Apr 12, 2021

skjnldsv commented on Apr 12, 2021

danxuliu commented on Apr 21, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions