You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Create sticky action buttons for table in Settings/User App #38215
Html structure of the table has been changed for a11y purposes: #36921.
During testing of new implementation some bugs regarding position: sticky and not right existing implementation of z-index of the action buttons have popped up. Demo:
There were 2 main problems:
During opening action menu of each row
During opening action menu of each row in editing mode
For the time reasons was decided to keep good / not broken state but without position: sticky which causes possible right scrolling inside of a table (from a11y perspective absolutely valid but not as user friendly as before), see #37870.
This is a follow-up ticket to correct action buttons to sticky position with current table implementation. There were some suggestions regarding implementation:
Current style was a bit incorrect:
.userActions had z-index: 10
.popovermenu had z-index: 110
.userActions is a parent of .popovermenu
A child cannot have z-index higher than parent
For position: relative we could just remove z-index: 10. But with position: sticky it works different... position: stickyalways creates a new stacking context. It is possible neither to remove z-index from sticky parent, nor to make child with higher z-index...
If I'm not wrong, the only way to keep sticky here is to use another container for NcActions here. For example, #app-content. But > I am really not sure, it positions element correct with sticky...
For an experiment, try to set container prop of NcActions here to #app-content.
@JuliaKirschenheuter I'm not sure if it's related, but in current NC27 I can't even see the action buttons if I enable further columns like "last login" or "user backend". They are then out of the viewable area and there's no horizontal scroll bar.
I can only see them when I click inside the text and mark it by moving to the right until they are viewable.
Activity
Chartman123 commentedon Jun 20, 2023
@JuliaKirschenheuter I'm not sure if it's related, but in current NC27 I can't even see the action buttons if I enable further columns like "last login" or "user backend". They are then out of the viewable area and there's no horizontal scroll bar.
I can only see them when I click inside the text and mark it by moving to the right until they are viewable.